Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: use Standard LoadBalancer as default #2998

Merged
merged 1 commit into from Apr 2, 2020

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Mar 31, 2020

Reason for Change:

This PR changes default cluster configuration enforcement so that Standard is the LoadBalancer SKU type if the user does not declare a loadBalancerSku value in the kubernetesConfig configuration object.

"Basic" LoadBalancer configuration is no longer appropriate as a default for cluster configurations, as it precludes running LoadBalancer-backed Kubernetes services behind multiple node pool-enabled clusters.

Folks who want to continue using the legacy "Basic" LoadBalancer type will have to explicitly declare so in their api model:

{
    "apiVersion": "vlabs",
    "properties": {
	"orchestratorProfile": {
		"orchestratorType": "Kubernetes",
			"kubernetesConfig": {
				"loadBalancerSku": "Basic",
...

Issue Fixed:

Fixes #2952

Requirements:

Notes:

@acs-bot acs-bot added the size/M label Mar 31, 2020
@jackfrancis
Copy link
Member Author

@craiglpeters @ritazh FYI

@acs-bot
Copy link

acs-bot commented Mar 31, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #2998 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2998      +/-   ##
==========================================
- Coverage   72.12%   72.11%   -0.02%     
==========================================
  Files         141      141              
  Lines       26257    26250       -7     
==========================================
- Hits        18937    18929       -8     
- Misses       6227     6228       +1     
  Partials     1093     1093              
Impacted Files Coverage Δ
pkg/api/defaults.go 92.20% <100.00%> (-0.09%) ⬇️
pkg/api/mocks.go 100.00% <100.00%> (ø)
pkg/api/types.go 94.26% <0.00%> (-0.90%) ⬇️
pkg/operations/kubernetesupgrade/upgrader.go 62.45% <0.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20854f3...20a7437. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis jackfrancis merged commit 7f301d2 into Azure:master Apr 2, 2020
@jackfrancis jackfrancis deleted the standard-lb-default branch April 2, 2020 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Standard LB by default
3 participants