fix: revert PodDisruptionBudget definitions

[jackfrancis]

In practice these are negatively impacting single master cluster cordon/drain scenarios (upgrade/scale)

Reason for Change:

Recently introduced PodDisruptionBudget definitions were preventing scale/upgrade scenarios for (at least) single master node cluster configurations:

time="2019-01-11T00:53:15Z" level=info msg="Node k8s-agent2-13795059-2 has been marked unschedulable." source="scaling command line"
time="2019-01-11T00:53:15Z" level=info msg="2 pods need to be removed/deleted" source="scaling command line"
time="2019-01-11T00:53:15Z" level=info msg="1 pods need to be removed/deleted" source="scaling command line"
time="2019-01-11T00:53:15Z" level=info msg="metrics-server-69b44566d5-vnqzx pod successfully evicted" source="scaling command line"
time="2019-01-11T00:53:15Z" level=info msg="kubernetes-dashboard-69f86d7cd9-kmz5r pod successfully evicted" source="scaling command line"
ERRO[3604] Failed to drain node k8s-agent2-13795059-1, got error Drain did not complete within 1h0m0s 
time="2019-01-11T01:53:15Z" level=error msg="There are pending pods when an error occurred: Drain did not complete within 1h0m0s\n" source="scaling command line"
time="2019-01-11T01:53:15Z" level=error msg="pod/coredns-d5b7bc49d-7d65l\n" source="scaling command line"

Issue Fixed:

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Notes:

[jackfrancis]

@sylr FYI

Let's aim to re-introduce this in a way that accounts for single master cluster configuration scenarios. Also, let's spend more time validating that only single master scenarios are what's preventing cordon/drain from finishing on scheduled pods with these PodDisruptionBudget definitions.

[codecov]

Codecov Report

Merging #300 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   53.16%   53.16%           
=======================================
  Files          95       95           
  Lines       14244    14244           
=======================================
  Hits         7573     7573           
  Misses       6006     6006           
  Partials      665      665

[mboersma]

lgtm

[CecileRobertMichon]

/lgtm

[acs-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment