Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: default to MCR for Kubernetes images #3046

Merged
merged 9 commits into from Apr 9, 2020

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Apr 8, 2020

Reason for Change:
Switches the default image base for Kubernetes components from k8s.gcr.io to mcr.microsoft.com.

This change was coming, but the switching of base URLs for new cluster-autoscaler releases has made it a priority.

Issue Fixed:
Refs #3024

Requirements:

Notes:

@mboersma mboersma changed the title feat: default to MCR for Kubernetes images [WIP] feat: default to MCR for Kubernetes images Apr 8, 2020
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #3046 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3046   +/-   ##
=======================================
  Coverage   70.62%   70.62%           
=======================================
  Files         145      145           
  Lines       25147    25147           
=======================================
  Hits        17761    17761           
  Misses       6283     6283           
  Partials     1103     1103           
Impacted Files Coverage Δ
pkg/api/addons.go 97.74% <100.00%> (ø)
pkg/api/components.go 96.89% <100.00%> (ø)
pkg/api/defaults.go 92.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66ff61c...6d80250. Read the comment docs.

@mboersma mboersma changed the title [WIP] feat: default to MCR for Kubernetes images feat: default to MCR for Kubernetes images Apr 9, 2020
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mboersma mboersma merged commit 76cd730 into Azure:master Apr 9, 2020
@mboersma mboersma deleted the default-to-mcr branch April 9, 2020 20:31
@mboersma
Copy link
Member Author

For more background on what nudged AKS Engine to make this change, see Kubernetes vanity domain flip.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants