This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: default to MCR for Kubernetes images #3046
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mboersma
changed the title
feat: default to MCR for Kubernetes images
[WIP] feat: default to MCR for Kubernetes images
Apr 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #3046 +/- ##
=======================================
Coverage 70.62% 70.62%
=======================================
Files 145 145
Lines 25147 25147
=======================================
Hits 17761 17761
Misses 6283 6283
Partials 1103 1103
Continue to review full report at Codecov.
|
4 tasks
mboersma
changed the title
[WIP] feat: default to MCR for Kubernetes images
feat: default to MCR for Kubernetes images
Apr 9, 2020
jackfrancis
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This was referenced Apr 9, 2020
For more background on what nudged AKS Engine to make this change, see Kubernetes vanity domain flip. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Switches the default image base for Kubernetes components from k8s.gcr.io to mcr.microsoft.com.
This change was coming, but the switching of base URLs for new cluster-autoscaler releases has made it a priority.
Issue Fixed:
Refs #3024
Requirements:
Notes: