This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: give metrics-server system-cluster-critical priority #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3082 +/- ##
==========================================
- Coverage 71.15% 70.85% -0.31%
==========================================
Files 145 145
Lines 25166 25274 +108
==========================================
Hits 17907 17907
- Misses 6143 6251 +108
Partials 1116 1116
Continue to review full report at Codecov.
|
|
Beautiful - that is exactly what I was looking for. (And what I had done to the add-on after it was deployed as a post-create fixup) Thank you! |
mboersma
force-pushed
the
metrics-are-critical
branch
from
1160567
to
9b2a661
Compare
alexeldeib
pushed a commit
to alexeldeib/aks-engine
that referenced
this pull request
Apr 21, 2020
* feat: give metrics-server system-cluster-critical priority * fix: almost forgot 1.14
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adds
priorityClassName: system-cluster-criticalto metrics-server pods so they are less likely to evicted under load.Issue Fixed:
Requirements:
Notes:
cc: @MichaelSinz