Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add support for Kubernetes 1.17.5 #3088

Merged
merged 1 commit into from Apr 17, 2020
Merged

feat: add support for Kubernetes 1.17.5 #3088

merged 1 commit into from Apr 17, 2020

Conversation

mboersma
Copy link
Member

Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.17.md#changelog-since-v1174

Issue Fixed:

Requirements:

  • Kubernetes artifacts built and pushed by Azure Pipelines
  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version

Notes:

@mboersma
Copy link
Member Author

/hold

This has a temporary commit for testing that should be discarded before merge.

@codecov
Copy link

codecov bot commented Apr 17, 2020 •
edited

Codecov Report

Merging #3088 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3088   +/-   ##
=======================================
  Coverage   70.63%   70.63%           
=======================================
  Files         147      147           
  Lines       25410    25410           
=======================================
  Hits        17949    17949           
  Misses       6340     6340           
  Partials     1121     1121
Impacted Files Coverage Δ
pkg/api/common/versions.go 96.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ebece1...8fdba1f. Read the comment docs.

@mboersma
Copy link
Member Author

This passed CI, so I will discard the temporary testing commit and it should be ready for review.

jackfrancis
jackfrancis reviewed Apr 17, 2020
View reviewed changes
vhd/packer/configure-windows-vhd.ps1
@@ -81,9 +81,9 @@ function Get-FilesToCacheOnVHD
"https://kubernetesartifacts.azureedge.net/kubernetes/v1.16.6/windowszip/v1.16.6-1int.zip",
"https://kubernetesartifacts.azureedge.net/kubernetes/v1.16.7/windowszip/v1.16.7-1int.zip",
"https://kubernetesartifacts.azureedge.net/kubernetes/v1.16.8/windowszip/v1.16.8-1int.zip",
"https://kubernetesartifacts.azureedge.net/kubernetes/v1.17.2/windowszip/v1.17.2-1int.zip",
"https://kubernetesartifacts.azureedge.net/kubernetes/v1.17.3/windowszip/v1.17.3-1int.zip",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to take one more version away here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT we have been keeping three patch versions around consistently in the Windows VHD. Intentional, or sloppy? @marosset?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional. So I think this PR is ready as-is.

@mboersma mboersma merged commit f99ffc0 into Azure:master Apr 17, 2020
@mboersma mboersma deleted the add-k8s-1.17.5 branch April 17, 2020 19:34
alexeldeib pushed a commit to alexeldeib/aks-engine that referenced this pull request Apr 21, 2020
@mboersma @alexeldeib
feat: add support for Kubernetes 1.17.5 (Azure#3088)
78ea23d 
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.17.md#changelog-since-v1174
@fmotrifork fmotrifork mentioned this pull request Apr 24, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackfrancis jackfrancis jackfrancis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mboersma @jackfrancis