Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add support for Kubernetes 1.19.0-alpha.2 #3122

Merged
merged 3 commits into from Apr 22, 2020

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Apr 22, 2020

Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.19.md#changelog-since-v1190-alpha1

Issue Fixed:

Requirements:

  • Kubernetes artifacts built and pushed by Azure Pipelines
  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version

Notes:
There is a problem building 1.19.0-alpha.2 currently in the Azure Pipeline. I will update this PR when we have it fixed. cc: @sozercan

@mboersma mboersma changed the title feat: add support for Kubernetes 1.19.0-alpha.2 [WIP] feat: add support for Kubernetes 1.19.0-alpha.2 Apr 22, 2020
@mboersma
Copy link
Member Author

This PR contains a temporary commit to run CI for 1.19. This commit should be discarded before merging.

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #3122 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3122      +/-   ##
==========================================
- Coverage   71.05%   71.04%   -0.02%     
==========================================
  Files         147      147              
  Lines       25671    25679       +8     
==========================================
+ Hits        18241    18244       +3     
- Misses       6294     6297       +3     
- Partials     1136     1138       +2     
Impacted Files Coverage Δ
pkg/api/common/versions.go 96.55% <ø> (ø)
pkg/engine/templates_generated.go 37.76% <ø> (ø)
pkg/api/converterfromapi.go 93.60% <0.00%> (-0.34%) ⬇️
pkg/api/convertertoapi.go 93.12% <0.00%> (-0.31%) ⬇️
pkg/api/types.go 94.37% <0.00%> (-0.09%) ⬇️
pkg/api/defaults.go 92.47% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c4e4a7...3f4a874. Read the comment docs.

@mboersma mboersma changed the title [WIP] feat: add support for Kubernetes 1.19.0-alpha.2 feat: add support for Kubernetes 1.19.0-alpha.2 Apr 22, 2020
@mboersma mboersma changed the title feat: add support for Kubernetes 1.19.0-alpha.2 [WIP] feat: add support for Kubernetes 1.19.0-alpha.2 Apr 22, 2020
@mboersma
Copy link
Member Author

This passed CI (modulo the "artifact upload" error), so I'll discard the testing commit and it should be ready for review.

@mboersma mboersma changed the title [WIP] feat: add support for Kubernetes 1.19.0-alpha.2 feat: add support for Kubernetes 1.19.0-alpha.2 Apr 22, 2020
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mboersma mboersma merged commit 17f9646 into Azure:master Apr 22, 2020
@mboersma mboersma deleted the add-k8s-1.19.0-alpha.2 branch April 22, 2020 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants