This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: don't hardcode csi enableproxy in kubeclusterconfig.json #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marosset
commented
Apr 22, 2020
| @@ -240,24 +240,24 @@ function Write-KubeClusterConfig { | |||
| } | |||
|
|
|||
| $Global:ClusterConfiguration | Add-Member -MemberType NoteProperty -Name Csi -Value @{ | |||
| EnableProxy = "true" | |||
| EnableProxy = $global:EnableCsiProxy | |||
There was a problem hiding this comment.
This is the bugfix, everything else is just whitespace cleanup
There was a problem hiding this comment.
Oh boy, thanks for fixing!
ksubrmnn
approved these changes
Apr 22, 2020
jackfrancis
pushed a commit
that referenced
this pull request
Apr 23, 2020
fix has been manually validated and we want to include this in v0.50.0
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
Jun 11, 2020
…3127) fix has been manually validated and we want to include this in v0.50.0
4 tasks
andyliuliming
pushed a commit
that referenced
this pull request
Jun 12, 2020
* chore: Add EnableAHUB in WindowsProfile (#3322) * Add LicenseType in WindowsProfile * fix run tests in parallel with same variable * Change LicenseType to EnableAHUB * Support LicenseType in VMAS * Update doc * Add E2E test config for Windows AHUB * fix: don't hardcode csi enableproxy in kubeclusterconfig.json (#3127) fix has been manually validated and we want to include this in v0.50.0 Co-authored-by: Mark Rossetti <marosset@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: