Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: fix e2e for custom clouds using ADFS #3150

Merged
merged 1 commit into from Apr 27, 2020

Conversation

jadarsie
Copy link
Member

Reason for Change:
Set IDENTITY_SYSTEM on tests triggered by cluster.sh to support ADFS identity provider.

Issue Fixed:
Related to #3117

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #3150 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3150   +/-   ##
=======================================
  Coverage   71.05%   71.05%           
=======================================
  Files         147      147           
  Lines       25687    25687           
=======================================
  Hits        18252    18252           
  Misses       6297     6297           
  Partials     1138     1138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b8b03...7c6a077. Read the comment docs.

@jadarsie
Copy link
Member Author

FYI, E2E passed, the PublishPipelineArtifact step failed

@jadarsie jadarsie requested a review from mboersma April 27, 2020 19:05
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry about creating work for you--I didn't realize the python3 switch in the dev image would have repercussions here.

@jadarsie
Copy link
Member Author

/lgtm

Sorry about creating work for you--I didn't realize the python3 switch in the dev image would have repercussions here.

np, I was a bad idea to hard-code in the first place

@jadarsie jadarsie merged commit a6a098b into Azure:master Apr 27, 2020
jadarsie added a commit to jadarsie/aks-engine that referenced this pull request Apr 28, 2020
haofan-ms pushed a commit to haofan-ms/aks-engine that referenced this pull request Jul 2, 2020
haofan-ms pushed a commit to haofan-ms/aks-engine that referenced this pull request Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants