Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: standardize to {{- for go template expressions #3166

Merged
merged 1 commit into from Apr 29, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This is follow-on work to go template-related cloud-init data reduction. Standardizes the cloud-init specs to use {{- where appropriate to ensure that no unnecessary add'l newlines result.

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #3166 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3166   +/-   ##
=======================================
  Coverage   71.13%   71.13%           
=======================================
  Files         147      147           
  Lines       25670    25670           
=======================================
  Hits        18261    18261           
  Misses       6272     6272           
  Partials     1137     1137           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 38.05% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5de8c8...99a3df9. Read the comment docs.

mboersma
mboersma previously approved these changes Apr 29, 2020
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Apr 29, 2020
@acs-bot
Copy link

acs-bot commented Apr 29, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit df94140 into Azure:master Apr 29, 2020
@jackfrancis jackfrancis deleted the cloud-init-whitespace branch April 29, 2020 23:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants