Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

refactor: consolidate azure-cni-networkmonitor addon spec #3189

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR consolidates the maintenance of the azure-cni-networkmonitor addon into a single go template-aware YAML file.

Issue Fixed:

Addresses #3188

Requirements:

Notes:

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #3189 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3189      +/-   ##
==========================================
- Coverage   71.24%   71.23%   -0.02%     
==========================================
  Files         147      147              
  Lines       25753    25732      -21     
==========================================
- Hits        18348    18329      -19     
+ Misses       6268     6258      -10     
- Partials     1137     1145       +8     
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 38.67% <0.00%> (+0.30%) ⬆️
pkg/engine/transform/apimodel_merger.go 70.90% <0.00%> (-5.29%) ⬇️
pkg/operations/kubernetesupgrade/upgradecluster.go 81.17% <0.00%> (-1.53%) ⬇️
pkg/armhelpers/azurestack/azureclient.go 28.68% <0.00%> (-0.78%) ⬇️
pkg/api/convertertoagentpoolonlyapi.go 89.93% <0.00%> (-0.59%) ⬇️
pkg/armhelpers/azureclient.go 35.41% <0.00%> (-0.54%) ⬇️
cmd/deploy.go 62.10% <0.00%> (-0.52%) ⬇️
cmd/upgrade.go 44.32% <0.00%> (-0.25%) ⬇️
pkg/armhelpers/converter.go 90.47% <0.00%> (-0.15%) ⬇️
pkg/armhelpers/azurestack/converter.go 90.47% <0.00%> (-0.15%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b357dc4...06c1e05. Read the comment docs.

backlog automation moved this from In progress to Review in progress May 4, 2020
mboersma
mboersma previously approved these changes May 4, 2020
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented May 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma removed the lgtm label May 4, 2020
@jackfrancis jackfrancis merged commit 2fe2def into Azure:master May 5, 2020
backlog automation moved this from Review in progress to Done May 5, 2020
@jackfrancis jackfrancis deleted the addons-consolidate-azure-cni-networkmonitor branch May 5, 2020 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants