fix: Add ILB for vmss masters #319
Conversation
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
+ Coverage 53.16% 53.17% +<.01%
==========================================
Files 95 95
Lines 14244 14247 +3
==========================================
+ Hits 7573 7576 +3
Misses 6006 6006
Partials 665 665 |
|
PR E2E failure is a flake on Windows test (no need to rerun) |
parts/k8s/kubernetesmastervars.t
Outdated
| {{else}} | ||
| "kubernetesAPIServerIP": "[concat(variables('masterFirstAddrPrefix'), add(variables('masterInternalLbIPOffset'), int(variables('masterFirstAddrOctet4'))))]", | ||
| {{end}} | ||
| {{else}} | ||
| "kubernetesAPIServerIP": "[parameters('firstConsecutiveStaticIP')]", | ||
| {{end}} | ||
| "masterLbBackendPoolName": "[concat(parameters('orchestratorName'), '-master-pool-', parameters('nameSuffix'))]", | ||
| "masterFirstAddr": "[parameters('firstConsecutiveStaticIP')]", |
There was a problem hiding this comment.
Can we continue to re-use the parameter instead of re-assigning to an ARM variable?
|
Functional validation of vmss master cluster configuration checks out. This lgtm after @tariq1890's suggestions are incorporated. Thanks so much! |
Co-Authored-By: ritazh <rita.z.zhang@gmail.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, ritazh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* fix: Add ILB for vmss masters * Add ut and e2e test * Update parts/k8s/kubernetesmastercustomdata.yml Co-Authored-By: ritazh <rita.z.zhang@gmail.com> * Remove masterFirstAddr variable
Reason for Change:
availabilityProfileisVirtualMachineScaleSetsandMasterProfile.Count > 1kubernetesAPIServerIPderived from"[concat(variables('masterFirstAddrOctets')[0],'.',variables('masterFirstAddrOctets')[1],'.255.', variables('masterInternalLbIPOffset'))]"e.g.10.240.255.10Issue Fixed:
Fixes #304
Requirements:
Notes: