Conversation
Codecov Report
@@ Coverage Diff @@
## master #3191 +/- ##
==========================================
+ Coverage 71.16% 71.22% +0.06%
==========================================
Files 147 147
Lines 25771 25738 -33
==========================================
- Hits 18339 18332 -7
+ Misses 6286 6261 -25
+ Partials 1146 1145 -1
Continue to review full report at Codecov.
|
pkg/armhelpers/azurestack/compute.go
Outdated
// Assume that all VMASes in the cluster share a value for platformFaultDomainCount | ||
count = int(*vmas.AvailabilitySetProperties.PlatformFaultDomainCount) | ||
break | ||
id := vmasIDs[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we check for len(vmasIDs) > 0 before doing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
The
staticcheck
linter is enabled by default in golangci-lint, although AKS Engine has had it disabled. It points out where errors are being assigned but not actually checked, and some other simplifications.Issue Fixed:
Refs #1032
Requirements:
Notes: