Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: updating cni to v1.1.2 #3192

Merged
merged 6 commits into from May 12, 2020
Merged

Conversation

tamilmani1989
Copy link
Member

@tamilmani1989 tamilmani1989 commented May 5, 2020

Reason for Change:

Upgrading cni to v.1.1.2.

  1. Has minor fixes
  2. Windows CNI dualstack support

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added the size/S label May 5, 2020
@tamilmani1989
Copy link
Member Author

/assign @jackfrancis

@jackfrancis
Copy link
Member

@jchauncey @sozercan do we have pre-existing pipeline jobs to publish new Azure CNI versions to our CDN endpoint?

@tamilmani1989
Copy link
Member Author

tamilmani1989 commented May 5, 2020

@jchauncey @sozercan do we have pre-existing pipeline jobs to publish new Azure CNI versions to our CDN endpoint?

@jackfrancis lets hold this. we are going to release new cni soon with windows dual stack support. Lets take that. Sorry for the inconvenience.

@matmerr
Copy link
Member

matmerr commented May 5, 2020

@jchauncey @sozercan do we have pre-existing pipeline jobs to publish new Azure CNI versions to our CDN endpoint?

We've added a pipeline job to publish new signed Azure CNI versions to our CDN endpoint if you're looking to mirror or pull directly

https://acnreleaseartifacts.azureedge.net/azure-cni/v1.1.1/binaries/azure-vnet-cni-singletenancy-windows-amd64-v1.1.1.zip

@jackfrancis jackfrancis added this to In progress in backlog May 6, 2020
@tamilmani1989 tamilmani1989 changed the title chore: updating cni to v1.1.1 chore: updating cni to v1.1.2 May 8, 2020
@tamilmani1989
Copy link
Member Author

@mboersma
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mboersma
Copy link
Member

Please remove backlog label

@tamilmani1989 "backlog" is used for our general set of work items. We attach that label mainly so the bot doesn't mark things as stale after 30 days. Sorry, that's probably not intuitive.

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #3192 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3192      +/-   ##
==========================================
+ Coverage   71.24%   71.43%   +0.18%     
==========================================
  Files         147      147              
  Lines       25753    25653     -100     
==========================================
- Hits        18348    18324      -24     
+ Misses       6268     6187      -81     
- Partials     1137     1142       +5     
Impacted Files Coverage Δ
pkg/engine/transform/apimodel_merger.go 70.90% <0.00%> (-5.29%) ⬇️
pkg/operations/kubernetesupgrade/upgradecluster.go 80.16% <0.00%> (-2.54%) ⬇️
cmd/get_logs.go 17.27% <0.00%> (-0.83%) ⬇️
pkg/armhelpers/azurestack/azureclient.go 28.68% <0.00%> (-0.78%) ⬇️
pkg/api/convertertoagentpoolonlyapi.go 89.93% <0.00%> (-0.59%) ⬇️
pkg/armhelpers/azureclient.go 35.41% <0.00%> (-0.54%) ⬇️
cmd/deploy.go 62.10% <0.00%> (-0.52%) ⬇️
cmd/upgrade.go 44.32% <0.00%> (-0.25%) ⬇️
pkg/armhelpers/converter.go 90.47% <0.00%> (-0.15%) ⬇️
pkg/armhelpers/azurestack/converter.go 90.47% <0.00%> (-0.15%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 662c433...72f7dbe. Read the comment docs.

@tamilmani1989
Copy link
Member Author

@mboersma can you please run azp again? The binaries are mirrored now.

@mboersma
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sozercan
Copy link
Member

sozercan commented May 11, 2020

i think windows zip needs to be renamed in the pr, it has singletenancy in the name now

@tamilmani1989
Copy link
Member Author

i think windows zip needs to be renamed in the pr, it has singletenancy in the name now

Ya noticed that. @matmerr we are not supposed to change zip name. can we rename and upload to storage account for now?

@tamilmani1989
Copy link
Member Author

ok free. I will update the url in PR

@tamilmani1989
Copy link
Member Author

@sozercan do you know why this test (AKS-Engine WS2019 VHD - docker) failed? I saw this:

"VM has reported a failure when processing extension 'vmssCSE'. Error message: "Command execution finished, but failed because it returned a non-zero exit code of: '1'."

@tamilmani1989
Copy link
Member Author

Let me check updating this file also -> pkg\api\azenvtypes.go

@tamilmani1989
Copy link
Member Author

@mboersma can you please start azp? looks like vhd passed

@mboersma
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tamilmani1989
Copy link
Member Author

@mboersma @sozercan can we merge this?

@sozercan
Copy link
Member

/lgtm

@mboersma
Copy link
Member

/approve

backlog automation moved this from In progress to Review in progress May 12, 2020
@mboersma mboersma merged commit c7109ed into Azure:master May 12, 2020
backlog automation moved this from Review in progress to Done May 12, 2020
@acs-bot
Copy link

acs-bot commented May 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma, sozercan, tamilmani1989

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants