Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

docs: rewrite monitoring topic #3205

Merged
merged 5 commits into from May 11, 2020

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented May 6, 2020

Reason for Change:
The monitoring doc was stale and needed a wholesale update.

Issue Fixed:
Fixes #3152
Fixes #3176

Requirements:

Notes:

@acs-bot acs-bot added the size/L label May 6, 2020
@mboersma mboersma changed the title docs: rewrite monitoring topic [WIP] docs: rewrite monitoring topic May 6, 2020
@mboersma mboersma added this to In progress in backlog via automation May 6, 2020
@mboersma
Copy link
Member Author

I'm not sure if we expect the prometheus-grafana monitoring extension to work still. I provisioned a cluster with the extension enabled but couldn't see that it did anything at all on my master or nodes.

I left that part of the doc as is, but if we don't expect that extension to work, I can remove it from the docs in general. Otherwise I'll file a bug that it's broken.

@mboersma mboersma changed the title [WIP] docs: rewrite monitoring topic docs: rewrite monitoring topic May 11, 2020
backlog automation moved this from In progress to Review in progress May 11, 2020
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This is awesome, thank you!

@acs-bot acs-bot added the lgtm label May 11, 2020
@jackfrancis jackfrancis merged commit 8973e40 into Azure:master May 11, 2020
backlog automation moved this from Review in progress to Done May 11, 2020
@acs-bot
Copy link

acs-bot commented May 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma deleted the but-who-monitors-the-docs branch May 11, 2020 19:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

monitoring docs are stale Update references to Heapster in monitoring doc
3 participants