refactor: consolidate metrics-server addon spec #3211
refactor: consolidate metrics-server addon spec #3211
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3211 +/- ##
==========================================
+ Coverage 71.37% 71.45% +0.07%
==========================================
Files 147 147
Lines 25687 25639 -48
==========================================
- Hits 18335 18320 -15
+ Misses 6207 6177 -30
+ Partials 1145 1142 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Just a couple of non-binding, spitballing, raise-the-flag-and-see-who-salutes kind of comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
This PR consolidates the maintenance of the
metrics-server
addon into a single go template-aware YAML file.Issue Fixed:
Addresses #3188
Requirements:
Notes: