Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

refactor: consolidate metrics-server addon spec #3211

Merged

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR consolidates the maintenance of the metrics-server addon into a single go template-aware YAML file.

Issue Fixed:

Addresses #3188

Requirements:

Notes:

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #3211 into master will increase coverage by 0.07%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3211      +/-   ##
==========================================
+ Coverage   71.37%   71.45%   +0.07%     
==========================================
  Files         147      147              
  Lines       25687    25639      -48     
==========================================
- Hits        18335    18320      -15     
+ Misses       6207     6177      -30     
+ Partials     1145     1142       -3     
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 39.64% <77.77%> (+0.01%) ⬆️
pkg/api/addons.go 97.88% <100.00%> (+<0.01%) ⬆️
pkg/engine/engine.go 85.95% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd276e...9040eac. Read the comment docs.

mboersma
mboersma previously approved these changes May 6, 2020
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Just a couple of non-binding, spitballing, raise-the-flag-and-see-who-salutes kind of comments.

pkg/api/addons.go Outdated Show resolved Hide resolved
pkg/engine/const.go Show resolved Hide resolved
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label May 7, 2020
@acs-bot
Copy link

acs-bot commented May 7, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma added this to In progress in backlog via automation May 11, 2020
@jackfrancis jackfrancis merged commit a9bc341 into Azure:master May 11, 2020
backlog automation moved this from In progress to Done May 11, 2020
@jackfrancis jackfrancis deleted the addons-consolidate-metrics-server branch May 11, 2020 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants