Conversation
/assign @jackfrancis |
Codecov Report
@@ Coverage Diff @@
## master #3225 +/- ##
==========================================
- Coverage 71.45% 71.43% -0.03%
==========================================
Files 147 147
Lines 25643 25653 +10
==========================================
Hits 18324 18324
- Misses 6177 6187 +10
Partials 1142 1142
Continue to review full report at Codecov.
|
b5e9df9
to
4759fd1
Compare
1.0.0-beta.6 > 1.11 is confusing, but documented as you pointed out. |
@mboersma yea nvidia also deprecated nvidia-docker2 but it's still required for k8s 😕 https://github.com/NVIDIA/nvidia-docker#upgrading-with-nvidia-docker2-deprecated |
I ran the % k logs -f cuda-vector-add
[Vector addition of 50000 elements]
Copy input data from the host memory to the CUDA device
CUDA kernel launch with 196 blocks of 256 threads
Copy output data from the CUDA device to the host memory
Test PASSED
Done The nodes report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma, sozercan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
updates nvidia-device-plugin version and moves the image to mcr
Note for versioning change from nvidia's side: https://github.com/NVIDIA/k8s-device-plugin#versioning
Issue Fixed:
Requirements:
Notes: