Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: update zip name for mooncake mirror #3237

Merged
merged 2 commits into from May 13, 2020
Merged

chore: update zip name for mooncake mirror #3237

merged 2 commits into from May 13, 2020

Conversation

tamilmani1989
Copy link
Member

Reason for Change:

This PR fixes zip name for windows package in mooncake mirror

Issue Fixed:

Requirements:

Notes:

@tamilmani1989
Copy link
Member Author

/assign @mboersma @sozercan

@mboersma
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented May 12, 2020 •
edited

Codecov Report

Merging #3237 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3237      +/-   ##
==========================================
+ Coverage   71.45%   71.46%   +0.01%     
==========================================
  Files         147      147              
  Lines       25671    25673       +2     
==========================================
+ Hits        18342    18346       +4     
+ Misses       6187     6186       -1     
+ Partials     1142     1141       -1
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 39.64% <0.00%> (ø)
pkg/engine/vmextensions.go 95.50% <0.00%> (+0.02%) ⬆️
pkg/engine/template_generator.go 81.57% <0.00%> (+0.10%) ⬆️
pkg/engine/virtualmachinescalesets.go 81.18% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7109ed...e250623. Read the comment docs.

mboersma
mboersma previously approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tamilmani1989
Copy link
Member Author

can @sozercan / @jchauncey confirm if this change is good?

@sozercan
Copy link
Member

@tamilmani1989 I believe we'll need to change the url to kubernetesartifacts.blob.core.chinacloudapi.cn (similar to CSIProxyDownloadURL) as mirror.azk8s.cn doesn't have this artifact.

@tamilmani1989
Copy link
Member Author

@tamilmani1989 I believe we'll need to change the url to kubernetesartifacts.blob.core.chinacloudapi.cn (similar to CSIProxyDownloadURL) as mirror.azk8s.cn doesn't have this artifact.

Ok i see all URLS need to be updated then. I'm not sure about other urls like ContainerdDownloadURLBase, CNIPluginsDownloadURL. do you want me to update for that also?

@tamilmani1989
Copy link
Member Author

also why are we not doing for other national clouds but only for mooncake?

@sozercan
Copy link
Member

sozercan commented May 12, 2020 •
edited

I don't think we are hosting those in kubernetesartifacts.blob.core.chinacloudapi.cn, just need the change for VnetCNIWindowsPluginsDownloadURL and VnetCNILinuxPluginsDownloadURL

I believe reason was to drop latency in mooncake

@mboersma mboersma removed the lgtm label May 12, 2020
@tamilmani1989
Copy link
Member Author

@sozercan I made the change. Please take a look .
@mboersma I dont think e2e is required. I changed for mooncake url and anyway e2e is not going to cover that.

@tamilmani1989
updated url for mooncake
e250623 
reverted unwanted change
@sozercan
Copy link
Member

/lgtm

@acs-bot acs-bot added the lgtm label May 12, 2020
@mboersma
Copy link
Member

I dont think e2e is required

No, but "azp run pr-e2e" is also the way to run the lint checks and unit tests as well.

@mboersma
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

mboersma
mboersma approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm++

@mboersma mboersma merged commit e93e0f3 into Azure:master May 13, 2020
@acs-bot
Copy link

acs-bot commented May 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma, sozercan, tamilmani1989

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

AbelHu pushed a commit to AbelHu/aks-engine that referenced this pull request May 15, 2020
@tamilmani1989 @AbelHu
chore: update zip name for mooncake mirror (Azure#3237)
8ac143f
@AbelHu AbelHu mentioned this pull request May 15, 2020
Merged
4 tasks
andyliuliming added a commit that referenced this pull request May 15, 2020
@AbelHu @mboersma
@marosset @tamilmani1989 @jackfrancis @andyliuliming @ksubrmnn
chore: Update Windows VHD image to 5B with some fixes (#3266)
899d49b 
* build: fetch k8s Windows .zip from kubernetesartifacts storage (#2655)

* build: fetch k8s Windows .zip from kubernetesartifacts storage

* docs: remove build-windows-k8s

* build: remove unsupported v1.15.5 from Windows VHD

* fix: generate windows .zip URL correctly for download

* test: update UT expectations for windowszip

* fix: Expose error details in Windows CSE (#3159)

* feat: Updating Windows VHDs to include May patches (#3263)

* chore: update zip name for mooncake mirror (#3237)

* chore: SinglePlacementGroup=false if VMSS + SLB (#3054)

* fix: the os disk size restriction is changed in azure. (#3043)

* refactor: Create signable PS scripts (#3015)

* feat: Refactor PS scripts to be static

* fix: don't hardcode pause image for containerD on Windows (#3158)

* chore: update Windows pause image (#3210)

* fix: USER_ASSIGNED_IDENTITY_ID is empty in azure.json (#3254)

Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com>
Co-authored-by: Mark Rossetti <marosset@microsoft.com>
Co-authored-by: tamilmani1989 <tamilmani1989@gmail.com>
Co-authored-by: Jack Francis <jackfrancis@gmail.com>
Co-authored-by: Liming Liu <andyliuliming@outlook.com>
Co-authored-by: Kalya Subramanian <42158129+ksubrmnn@users.noreply.github.com>
@AbelHu AbelHu mentioned this pull request May 15, 2020
Merged
4 tasks
@fmotrifork fmotrifork mentioned this pull request May 26, 2020
Merged
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
@tamilmani1989 @penggu
chore: update zip name for mooncake mirror (Azure#3237)
f1b65cd
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mboersma mboersma mboersma approved these changes

Assignees

@mboersma mboersma

@sozercan sozercan

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tamilmani1989 @mboersma @sozercan @acs-bot