This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: don't dry-run cluster-init spec #3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #3247 +/- ##
=======================================
Coverage 71.55% 71.55%
=======================================
Files 147 147
Lines 25635 25635
=======================================
Hits 18342 18342
Misses 6151 6151
Partials 1142 1142
Continue to review full report at Codecov.
|
jackfrancis
force-pushed
the
cluster-init-no-dry-run
branch
from
ab3166b
to
be55522
Compare
|
New changes are detected. LGTM label has been removed. |
jackfrancis
added a commit
that referenced
this pull request
May 13, 2020
penggu
pushed a commit
to penggu/aks-engine
that referenced
this pull request
Oct 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR removes the
--server-dry-run=trueoption fromkubectl applyduring cluster-init reconciliation. Strictly speaking, we should not need to validate the entire spec before runningkubectl apply, as retries of that command should reconcile the spec if < 100% was successful the 1st time around.Issue Fixed:
Fixes #3234
Requirements:
Notes: