Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

refactor: consolidate azure-cloud-provider addon spec #3277

Merged

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR consolidates the maintenance of the azure-cloud-provider addon into a single go template-aware YAML file.

Issue Fixed:

Addresses #3188

Requirements:

Notes:

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #3277 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3277      +/-   ##
==========================================
+ Coverage   71.55%   71.64%   +0.09%     
==========================================
  Files         147      147              
  Lines       25628    25583      -45     
==========================================
- Hits        18337    18330       -7     
+ Misses       6152     6115      -37     
+ Partials     1139     1138       -1     
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 40.70% <ø> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update febebda...c35943b. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented May 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 0e7205f into Azure:master May 18, 2020
@jackfrancis jackfrancis deleted the addons-consolidate-cloudprovider branch May 18, 2020 16:31
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants