Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: update coredns to 1.6.9 #3328

Merged
merged 1 commit into from
May 26, 2020
Merged

chore: update coredns to 1.6.9 #3328

merged 1 commit into from
May 26, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR updates the AKS Engine-provided version of coredns to v1.6.9. See:

https://github.com/coredns/coredns/releases/tag/v1.6.9

Issue Fixed:

Requirements:

Notes:

jackfrancis
jackfrancis commented May 22, 2020
View reviewed changes
pkg/api/k8s_versions.go
@@ -85,7 +85,7 @@ var kubernetesImageBaseDefaultImages = map[string]map[string]string{
common.DashboardMetricsScraperContainerName: "oss/kubernetes/metrics-scraper:v1.0.4",
common.ExecHealthZComponentName: "oss/kubernetes/exechealthz:1.2",
common.HeapsterAddonName: "oss/kubernetes/heapster:v1.5.4",
common.CoreDNSAddonName: "oss/kubernetes/coredns:1.6.7",
common.CoreDNSAddonName: "oss/kubernetes/coredns:1.6.9",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like updates to coredns are no longer being publicly hosted here:

https://console.cloud.google.com/gcr/images/google-containers/GLOBAL/coredns?gcrImageListsize=30

So, just updating the MCR source

@jackfrancis jackfrancis mentioned this pull request May 22, 2020
Closed
@codecov
Copy link

codecov bot commented May 22, 2020 •
edited

Codecov Report

Merging #3328 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3328   +/-   ##
=======================================
  Coverage   72.11%   72.11%           
=======================================
  Files         147      147           
  Lines       25455    25455           
=======================================
  Hits        18357    18357           
  Misses       5959     5959           
  Partials     1139     1139
Impacted Files Coverage Δ
pkg/api/k8s_versions.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5206783...b3f02d2. Read the comment docs.

mboersma
mboersma approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label May 26, 2020
@acs-bot
Copy link

acs-bot commented May 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 77363ec into Azure:master May 26, 2020
@jackfrancis jackfrancis deleted the coredns-1.6.9 branch May 26, 2020 17:07
@fmotrifork fmotrifork mentioned this pull request Jun 8, 2020
Merged
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
@jackfrancis @penggu
chore: rev coredns to 1.6.9 (Azure#3328)
ac72311
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mboersma mboersma mboersma approved these changes

Assignees

@mboersma mboersma

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jackfrancis @acs-bot @mboersma