Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: k8s v1.17 conformance model for Azure Stack #3338

Merged
merged 1 commit into from
May 26, 2020

Conversation

jadarsie
Copy link
Member

Reason for Change:
Add cluster definition required to replicate k8s-conformance for v1.17
Related: cncf/k8s-conformance#979

@acs-bot acs-bot added the size/M label May 26, 2020
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #3338 into master will increase coverage by 0.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3338      +/-   ##
==========================================
+ Coverage   71.16%   72.11%   +0.95%     
==========================================
  Files         147      147              
  Lines       25771    25455     -316     
==========================================
+ Hits        18339    18357      +18     
+ Misses       6286     5959     -327     
+ Partials     1146     1139       -7     
Impacted Files Coverage Δ
pkg/operations/kubernetesupgrade/upgradecluster.go 80.16% <0.00%> (-1.01%) ⬇️
cmd/get_logs.go 17.27% <0.00%> (-0.83%) ⬇️
pkg/armhelpers/httpMockClient.go 57.94% <0.00%> (-0.52%) ⬇️
cmd/scale.go 12.18% <0.00%> (-0.18%) ⬇️
pkg/engine/armvariables.go 86.14% <0.00%> (-0.03%) ⬇️
pkg/api/types.go 94.35% <0.00%> (-0.02%) ⬇️
pkg/engine/cse.go 100.00% <0.00%> (ø)
pkg/api/vlabs/types.go 73.30% <0.00%> (ø)
pkg/api/common/const.go 40.00% <0.00%> (ø)
pkg/api/k8s_versions.go 100.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce2924...33b3792. Read the comment docs.

@jadarsie jadarsie requested a review from mboersma May 26, 2020 18:01
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label May 26, 2020
@jackfrancis jackfrancis merged commit 71b74cf into Azure:master May 26, 2020
@acs-bot
Copy link

acs-bot commented May 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jadarsie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants