Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

refactor: consolidate aci-connector addon spec #3358

Merged

Conversation

jackfrancis
Copy link
Member

Reason for Change:

Eases maintenance of the aci-connector addon by consolidating manifests into a single YAML file that uses Go templating.

Issue Fixed:

Addresses #3188.

Requirements:

Notes:

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #3358 into master will decrease coverage by 0.10%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3358      +/-   ##
==========================================
- Coverage   72.37%   72.26%   -0.11%     
==========================================
  Files         147      147              
  Lines       25305    25383      +78     
==========================================
+ Hits        18314    18343      +29     
- Misses       5856     5903      +47     
- Partials     1135     1137       +2     
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 45.35% <77.77%> (-0.83%) ⬇️
pkg/api/defaults.go 92.65% <0.00%> (+0.06%) ⬆️
pkg/api/vlabs/validate.go 80.52% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8515615...4c9d30e. Read the comment docs.

mboersma
mboersma previously approved these changes May 29, 2020
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label May 29, 2020
@mboersma mboersma added the needs-rebase Changes in the target branch require a `git rebase` and `git push -f` label May 29, 2020
@acs-bot
Copy link

acs-bot commented May 29, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot
Copy link

acs-bot commented May 29, 2020

New changes are detected. LGTM label has been removed.

@acs-bot acs-bot removed the lgtm label May 29, 2020
@jackfrancis jackfrancis merged commit db6600c into Azure:master May 29, 2020
@jackfrancis jackfrancis deleted the addons-consolidate-aci-connector branch May 29, 2020 18:11
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved needs-rebase Changes in the target branch require a `git rebase` and `git push -f` size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants