This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
refactor: consolidate calico addon spec #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3361 +/- ##
==========================================
+ Coverage 72.37% 72.45% +0.07%
==========================================
Files 147 147
Lines 25305 25278 -27
==========================================
Hits 18314 18314
+ Misses 5856 5829 -27
Partials 1135 1135
Continue to review full report at Codecov.
|
jackfrancis
force-pushed
the
addons-consolidate-calico
branch
from
3fc8f6f
to
b58cf10
Compare
jackfrancis
force-pushed
the
addons-consolidate-calico
branch
from
0639110
to
f63eda2
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Eases maintenance of the calico addon by consolidating manifests into a single YAML file that uses Go templating.
Maintaining a 1.15-specific addon spec for calico as it includes a bunch of differences that suggest a directory-specific file is the appropriate maintenance choice here.
Issue Fixed:
Addresses #3188.
Requirements:
Notes: