Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

refactor: consolidate cloud-node-manager addon spec #3363

Merged

Conversation

jackfrancis
Copy link
Member

Reason for Change:

Eases maintenance of the cloud-node-manager addon by consolidating manifests into a single YAML file that uses Go templating.
Issue Fixed:

Addresses #3188.

Requirements:

Notes:

@acs-bot acs-bot added the size/L label May 28, 2020
@@ -93,7 +93,7 @@ spec:
limits:
cpu: 2000m
memory: 512Mi
{{- if HasWindows}}
{{- if and HasWindows (IsKubernetesVersionGe "1.18.0")}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @chewong to sanity check that this is the only version-specific aspect of this spec

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right.

@acs-bot
Copy link

acs-bot commented May 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot acs-bot added size/XXL and removed size/L labels May 28, 2020
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #3363 into master will increase coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3363      +/-   ##
==========================================
+ Coverage   72.16%   72.23%   +0.07%     
==========================================
  Files         147      147              
  Lines       25419    25392      -27     
==========================================
  Hits        18343    18343              
+ Misses       5939     5912      -27     
  Partials     1137     1137              
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 45.13% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d75e6e...c8aaee9. Read the comment docs.

@jackfrancis jackfrancis merged commit f82b8e9 into Azure:master May 29, 2020
@jackfrancis jackfrancis deleted the addons-consolidate-cloud-node-manager branch May 29, 2020 00:03
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants