Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: use nvidia drivers version 418.126.02 for 18.04 #3366

Merged
merged 1 commit into from
May 28, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR re-enables N series for Ubuntu 18.04-LTS using nvidia drivers version 418.126.02.

Issue Fixed:

Fixes #3269
Fixes #3274

Requirements:

Notes:

@jackfrancis
Copy link
Member Author

Thank you @xuto!

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #3366 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3366      +/-   ##
==========================================
- Coverage   72.16%   72.14%   -0.02%     
==========================================
  Files         147      147              
  Lines       25419    25404      -15     
==========================================
- Hits        18343    18328      -15     
  Misses       5939     5939              
  Partials     1137     1137              
Impacted Files Coverage Δ
pkg/api/vlabs/validate.go 80.37% <ø> (-0.16%) ⬇️
pkg/engine/templates_generated.go 44.47% <ø> (ø)
pkg/api/defaults.go 92.58% <100.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d75e6e...67a4812. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis
Copy link
Member Author

Validated successful 18.04 VHD build

@Michael-Sinz
Copy link
Collaborator

/lgtm

@acs-bot
Copy link

acs-bot commented May 28, 2020

@Michael-Sinz: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@acs-bot
Copy link

acs-bot commented May 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma, Michael-Sinz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 95d6127 into Azure:master May 28, 2020
@jackfrancis jackfrancis deleted the nvidia-enable-18.04 branch May 28, 2020 22:15
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable nvidia for 18.04-LTS Seeing nvidia installation errors in 5.3.0-1020-azure-backed GPU nodes
4 participants