fix: bypass AzurePublicCloud assumption in e2e suite #3371
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3371 +/- ##
==========================================
+ Coverage 72.16% 72.57% +0.41%
==========================================
Files 147 147
Lines 25419 25215 -204
==========================================
- Hits 18343 18300 -43
+ Misses 5939 5782 -157
+ Partials 1137 1133 -4
Continue to review full report at Codecov.
|
| @@ -2146,7 +2148,7 @@ var _ = Describe("Azure Container Cluster using the Kubernetes Orchestrator", fu | |||
| break | |||
| } | |||
| } | |||
|
|
|||
| // TODO refactor to remove the "compute" usage so the test can be run on Azure Stack | |||
There was a problem hiding this comment.
We're O.K. with leaving this TODO as is? This means these tests will fail, right?
There was a problem hiding this comment.
(fail in Azure Stack, that is)
There was a problem hiding this comment.
OK, for now, it wont get to this point as we do not yet support VMSS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, jadarsie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
E2E should not hard-code public Azure cloud as it breaks custom clouds running E2E.
This PR is not a proper fix, it just makes things work again for Azure Stack.
Introduced here PR #3144.
Requirements:
Notes: