Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

refactor: consolidate flannel addon spec #3385

Merged
merged 2 commits into from
Jun 2, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

Eases maintenance of the flannel addon by consolidating manifests into a single YAML file that uses Go templating.

Issue Fixed:

Addresses #3188.

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #3385 into master will increase coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3385      +/-   ##
==========================================
+ Coverage   72.60%   72.70%   +0.10%     
==========================================
  Files         147      147              
  Lines       25206    25170      -36     
==========================================
  Hits        18300    18300              
+ Misses       5773     5737      -36     
  Partials     1133     1133              
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 49.16% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 444ae63...0b5124b. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Jun 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit a73a167 into Azure:master Jun 2, 2020
@jackfrancis jackfrancis deleted the addons-consolidate-flannel branch June 2, 2020 23:19
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants