This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: deprecate heapster addon #3387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3387 +/- ##
==========================================
- Coverage 72.88% 72.63% -0.26%
==========================================
Files 147 147
Lines 25098 25122 +24
==========================================
- Hits 18293 18247 -46
- Misses 5673 5744 +71
+ Partials 1132 1131 -1
Continue to review full report at Codecov.
|
mboersma
previously approved these changes
Jun 2, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jackfrancis
force-pushed
the
addons-deprecate-heapster
branch
from
493c0b4
to
4c8a309
Compare
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR removes the
heapsteraddon entirely. Heapster has been functionally deprecated in AKS Engine-created clusters since Kubernetes 1.12. In practice it's not clear if the legacy heapster addon spec actually works (we should assume it functionally conflicts w/ metrics-server), so we're doing some cleanup as the best way of removing unnecessary maintenance going forward.Issue Fixed:
Requirements:
Notes: