Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

refactor: consolidate kube-dns addon spec #3390

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

Eases maintenance of the kube-dns addon by consolidating manifests into a single YAML file that uses Go templating.

Issue Fixed:

Addresses #3188.

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #3390 into master will increase coverage by 0.02%.
The diff coverage is 36.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3390      +/-   ##
==========================================
+ Coverage   72.67%   72.70%   +0.02%     
==========================================
  Files         147      147              
  Lines       25170    25170              
==========================================
+ Hits        18293    18300       +7     
+ Misses       5745     5737       -8     
- Partials     1132     1133       +1     
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 49.16% <36.84%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 504d398...3b394e8. Read the comment docs.

mboersma
mboersma previously approved these changes Jun 2, 2020
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Jun 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot
Copy link

acs-bot commented Jun 2, 2020

New changes are detected. LGTM label has been removed.

@acs-bot acs-bot removed the lgtm label Jun 2, 2020
@jackfrancis jackfrancis merged commit ac6d522 into Azure:master Jun 2, 2020
@jackfrancis jackfrancis deleted the addons-consolidate-kube-dns branch June 2, 2020 23:41
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants