Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

refactor: consolidate tiller addon spec #3399

Merged
merged 2 commits into from
Jun 3, 2020

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Jun 3, 2020

Reason for Change:

Eases maintenance of the tiller addon by consolidating manifests into a single YAML file that uses Go templating.

Issue Fixed:

Fixes #3188.

Requirements:

Notes:

@acs-bot
Copy link

acs-bot commented Jun 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #3399 into master will increase coverage by 0.06%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3399      +/-   ##
==========================================
+ Coverage   73.07%   73.14%   +0.06%     
==========================================
  Files         147      147              
  Lines       24945    24909      -36     
==========================================
- Hits        18229    18220       -9     
+ Misses       5588     5561      -27     
  Partials     1128     1128              
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 54.08% <77.77%> (+0.87%) ⬆️
pkg/engine/artifacts.go 99.12% <0.00%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edf8c6e...a2b122a. Read the comment docs.

@jackfrancis jackfrancis merged commit 99c4d55 into Azure:master Jun 3, 2020
@jackfrancis jackfrancis deleted the addons-consolidate-tiller branch June 3, 2020 22:42
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consolidate addons specs in single files
2 participants