Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: standardize nodeSelectors #3406

Merged
merged 3 commits into from
Jun 4, 2020
Merged

Conversation

jackfrancis
Copy link
Member

Reason for Change:

Standardizes nodeSelector

Issue Fixed:

Fixes #3351

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #3406 into master will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3406      +/-   ##
==========================================
+ Coverage   73.07%   73.17%   +0.10%     
==========================================
  Files         147      147              
  Lines       24945    24923      -22     
==========================================
+ Hits        18229    18238       +9     
+ Misses       5588     5559      -29     
+ Partials     1128     1126       -2     
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 54.08% <ø> (+0.87%) ⬆️
pkg/engine/artifacts.go 99.12% <0.00%> (-0.88%) ⬇️
pkg/api/vlabs/types.go 73.30% <0.00%> (ø)
pkg/api/types.go 94.37% <0.00%> (+0.02%) ⬆️
pkg/engine/virtualmachinescalesets.go 81.28% <0.00%> (+0.09%) ⬆️
pkg/engine/virtualmachines.go 80.98% <0.00%> (+0.13%) ⬆️
pkg/api/convertertoapi.go 93.50% <0.00%> (+0.33%) ⬆️
pkg/api/converterfromapi.go 94.01% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edf8c6e...db07442. Read the comment docs.

@mboersma mboersma added this to In progress in backlog via automation Jun 4, 2020
backlog automation moved this from In progress to Review in progress Jun 4, 2020
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Jun 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit dcc73fb into Azure:master Jun 4, 2020
backlog automation moved this from Review in progress to Done Jun 4, 2020
@jackfrancis jackfrancis deleted the nodeSelectors branch June 4, 2020 23:45
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

ensure addons have the right nodeSelector values
3 participants