Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: Disable failing kubnet tests #3436

Merged
merged 4 commits into from Jun 10, 2020

Conversation

jsturtevant
Copy link
Contributor

Reason for Change:

Disables failing tests in where kubenet does not work with node restarts. Disabling the tests as kubenet is used for Debugging/test scenarios.

Issue Fixed:

Addresses #3429 and #3435

Requirements:

Notes:
Currently Windows + Kubenet is for development and testing only, not recommended for production

@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #3436 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3436   +/-   ##
=======================================
  Coverage   73.20%   73.20%           
=======================================
  Files         147      147           
  Lines       24970    24972    +2     
=======================================
+ Hits        18279    18281    +2     
  Misses       5562     5562           
  Partials     1129     1129           
Impacted Files Coverage Δ
pkg/api/vlabs/validate.go 80.26% <100.00%> (+0.03%) ⬆️
pkg/api/defaults-apiserver.go 100.00% <0.00%> (ø)
pkg/engine/templates_generated.go 54.08% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3346da...945ba1e. Read the comment docs.

@acs-bot acs-bot added size/M and removed size/S labels Jun 10, 2020
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Jun 10, 2020
@jackfrancis jackfrancis merged commit 9cc71eb into Azure:master Jun 10, 2020
@acs-bot
Copy link

acs-bot commented Jun 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marosset
Copy link
Contributor

/lgtm

penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants