Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Add "1.13" coverage to TestGetK8sVersionComponents unit tests #346

Closed
jackfrancis opened this issue Jan 22, 2019 · 2 comments · Fixed by #383
Closed

Add "1.13" coverage to TestGetK8sVersionComponents unit tests #346

jackfrancis opened this issue Jan 22, 2019 · 2 comments · Fixed by #383
Assignees
@serbrech
Labels
area/test

Comments

@jackfrancis
Copy link
Member

This coverage was never added when we first released 1.13.

See the "1.14" additions in this PR as a reference:

https://github.com/Azure/aks-engine/pull/330/files#diff-bb9b6cb6f08a63800be959ba49eaf714R16
@serbrech
Copy link
Member

@francis #330 you reference wasn't merged, maybe it's best to push there to avoid unnecessary conflicts?

@CecileRobertMichon
Copy link
Contributor

#330 is merged now

@serbrech serbrech mentioned this issue Jan 25, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@serbrech serbrech

Labels
area/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add k8s components versions test 1.13 serbrech/aks-engine
3 participants
@serbrech @jackfrancis @CecileRobertMichon