Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: Add June Windows Patches #3468

Merged
merged 1 commit into from Jun 15, 2020

Conversation

jsturtevant
Copy link
Contributor

Reason for Change:

Adds release notes and updates default windows image to use June's patches

Issue Fixed:

Requirements:

Notes:
CC: @AbelHu

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Jun 12, 2020
@jackfrancis jackfrancis changed the title chore: Add June Patches chore: Add June Windows Patches Jun 12, 2020
@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #3468 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3468   +/-   ##
=======================================
  Coverage   73.16%   73.16%           
=======================================
  Files         147      147           
  Lines       25024    25024           
=======================================
  Hits        18310    18310           
  Misses       5580     5580           
  Partials     1134     1134           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7064ab1...e45cffd. Read the comment docs.

@@ -182,7 +182,7 @@ var (
ImageOffer: "aks-windows",
ImageSku: "2019-datacenter-core-smalldisk-2006",
ImagePublisher: "microsoft-aks",
ImageVersion: "17763.1217.200603",
ImageVersion: "17763.1282.200610",
}

// WindowsServer2019OSImageConfig is the 'vanilla' Windows Server 2019 image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this one to use the same ImageVersion the aks-windows VHD was based off of?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the vanilla windows server the June patches haven't been released as an image yet. So I believe does match: https://github.com/Azure/aks-engine/pull/3439/files#diff-d61a27407ad48d7a4154938c47584c43

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow - yea.
I've never seen the -with-containers image not get released at the same time as the vanilla WS2019 images..

@marosset
Copy link
Contributor

/lgtm

@marosset
Copy link
Contributor

/cc @AbelHu

@acs-bot acs-bot requested a review from AbelHu June 12, 2020 23:16
@AbelHu
Copy link
Member

AbelHu commented Jun 15, 2020

/lgtm

@acs-bot
Copy link

acs-bot commented Jun 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AbelHu, jackfrancis, jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 7f7af61 into Azure:master Jun 15, 2020
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants