chore: Add June Windows Patches #3468
chore: Add June Windows Patches #3468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov Report
@@ Coverage Diff @@
## master #3468 +/- ##
=======================================
Coverage 73.16% 73.16%
=======================================
Files 147 147
Lines 25024 25024
=======================================
Hits 18310 18310
Misses 5580 5580
Partials 1134 1134 Continue to review full report at Codecov.
|
@@ -182,7 +182,7 @@ var ( | |||
ImageOffer: "aks-windows", | |||
ImageSku: "2019-datacenter-core-smalldisk-2006", | |||
ImagePublisher: "microsoft-aks", | |||
ImageVersion: "17763.1217.200603", | |||
ImageVersion: "17763.1282.200610", | |||
} | |||
|
|||
// WindowsServer2019OSImageConfig is the 'vanilla' Windows Server 2019 image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update this one to use the same ImageVersion the aks-windows VHD was based off of?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the vanilla windows server the June patches haven't been released as an image yet. So I believe does match: https://github.com/Azure/aks-engine/pull/3439/files#diff-d61a27407ad48d7a4154938c47584c43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow - yea.
I've never seen the -with-containers image not get released at the same time as the vanilla WS2019 images..
/lgtm |
/cc @AbelHu |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AbelHu, jackfrancis, jsturtevant, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Adds release notes and updates default windows image to use June's patches
Issue Fixed:
Requirements:
Notes:
CC: @AbelHu