Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: ensure all AKS required ports on api-server are exposed #3488

Merged

Conversation

gtracer
Copy link
Contributor

@gtracer gtracer commented Jun 16, 2020

Reason for Change:

AKS requires two ports to be exposed beyond 443. These ports are used for tunnelfront to connect to tunnelend and when customers block them (firewall etc.) it causes clusters to fail

Issue Fixed:

Requirements:

Notes:
Looks to me like the apiserver connection check is sectioned to aks only since it is for hosted master but if that is wrong and aks-engine clusters could also trigger this code then please let me know as these ports are only needed for aks clusters

@jackfrancis
Copy link
Member

Hi @gtracer, if you run make generate and then commit the resultant generated code we can kick off E2E

@acs-bot acs-bot added size/S and removed size/XS labels Jun 16, 2020
@jveski
Copy link

jveski commented Jun 16, 2020

lgtm for the tunnel ports 👍

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@acs-bot
Copy link

acs-bot commented Jun 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtracer, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #3488 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3488   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files         147      147           
  Lines       25040    25040           
=======================================
  Hits        18323    18323           
  Misses       5583     5583           
  Partials     1134     1134           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 54.08% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba3a01b...5dc194b. Read the comment docs.

@jackfrancis jackfrancis merged commit 536e889 into Azure:master Jun 16, 2020
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants