Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add support for Kubernetes v1.16.12 #3551

Merged
merged 3 commits into from
Jun 30, 2020

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Jun 26, 2020

Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.16.md#changelog-since-v11611

Issue Fixed:

Requirements:

  • Kubernetes artifacts built and pushed by Azure Pipelines
  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version

Notes:

@acs-bot acs-bot added the size/S label Jun 26, 2020
@mboersma
Copy link
Member Author

/hold

This has a temporary commit for testing that should be discarded before merging.

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #3551 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3551   +/-   ##
=======================================
  Coverage   73.19%   73.19%           
=======================================
  Files         147      147           
  Lines       25078    25078           
=======================================
  Hits        18355    18355           
  Misses       5589     5589           
  Partials     1134     1134           
Impacted Files Coverage Δ
pkg/api/common/versions.go 96.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d35e62d...eeeedd6. Read the comment docs.

@mboersma
Copy link
Member Author

mboersma commented Jun 26, 2020

This passed CI, so I'll strip off the testing commit and it should be ready for review.

@mboersma
Copy link
Member Author

/hold cancel

Copy link

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #3532, kube-proxy image is used for kube-proxy container instead of hyperkube. Could you add 1.16.12 in https://github.com/Azure/aks-engine/blob/master/vhd/packer/install-dependencies.sh#L384-L392?

@mboersma
Copy link
Member Author

Could you add [kube-proxy] 1.16.12...

Good catch! Added.

@chewong
Copy link

chewong commented Jun 30, 2020

/hold
I think there are plans to drop 1.16.11 support after v0.53.0 is released and resume using hyperkube for kube-proxy image.

@jackfrancis
Copy link
Member

@chewong @mboersma we don't need to worry about dropping v1.16.11 with this change, we can continue to include 1.16 kube-proxy artifacts in the VHD spec as @chewong pointed out earlier in this PR thread. We're good on that path!

@jackfrancis
Copy link
Member

/hold release

jackfrancis
jackfrancis previously approved these changes Jun 30, 2020
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Jun 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot
Copy link

acs-bot commented Jun 30, 2020

New changes are detected. LGTM label has been removed.

@mboersma
Copy link
Member Author

/hold cancel

@mboersma mboersma merged commit 316106e into Azure:master Jun 30, 2020
@mboersma mboersma deleted the add-k8s-1.16.12 branch June 30, 2020 17:38
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants