This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: change addons image pull policy to IfNotPresent #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3562 +/- ##
=======================================
Coverage 73.19% 73.19%
=======================================
Files 147 147
Lines 25078 25078
=======================================
Hits 18355 18355
Misses 5589 5589
Partials 1134 1134
Continue to review full report at Codecov.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jadarsie, mboersma, sozercan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
penggu
pushed a commit
to penggu/aks-engine
that referenced
this pull request
Oct 28, 2020
* fix: change addons image pull policy to IfNotPresent * make generate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Addon manifests that set
imagePullPolicy: Alwayswont be functional (ImagePullBackOff) after upgrading an air-gaped environment, even if the required image is in the upgrade VHD.Switching to
IfNotPresentwill prevent this problem.Requirements:
Notes: