Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: set update strategy for the azure-cnms addon #3571

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

jadarsie
Copy link
Member

@jadarsie jadarsie commented Jul 2, 2020

Reason for Change:
Our air-gap validations show that the azure-cni-networkmonitor pods running on control-plane nodes do not reach the Running state after an upgrade operation (AKSe v0.48+K8s v1.15 to v1.16). Switching updateStrategy.type to RollingUpdate (from default OnDelete) fixes the problem.

Requirements:

Notes:
Should we update all addons updateStrategy?

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #3571 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3571   +/-   ##
=======================================
  Coverage   73.19%   73.19%           
=======================================
  Files         147      147           
  Lines       25078    25078           
=======================================
  Hits        18355    18355           
  Misses       5589     5589           
  Partials     1134     1134           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 54.08% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ee4f53...0b3b434. Read the comment docs.

@jadarsie jadarsie changed the title chore: set explicty update strategy for the azure-cnms addon chore: set update strategy for the azure-cnms addon Jul 2, 2020
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Jul 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jadarsie, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jadarsie jadarsie merged commit dc50699 into Azure:master Jul 2, 2020
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants