Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: e2e driver pass identity system to upgrade and scale commands #3582

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

haofan-ms
Copy link
Contributor

@haofan-ms haofan-ms commented Jul 7, 2020

Reason for Change:

The previous e2e test was failing on Azure Stack ADFS environment, as there was no --identity-system parameter in the aks-engine scale and aks-engine upgrade commands.

BTW: the documentation about scale and upgrade may need an update as well.

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added the size/XS label Jul 7, 2020
@haofan-ms haofan-ms requested a review from jadarsie July 7, 2020 19:37
@jadarsie jadarsie changed the title fix: update akse upgrade and scale in the e2e test to include identity system param test: e2e driver pass identity system to upgrade and scale commands Jul 7, 2020
@jadarsie
Copy link
Member

jadarsie commented Jul 7, 2020

lgtm

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #3582 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3582   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files         147      147           
  Lines       25110    25110           
=======================================
  Hits        18373    18373           
  Misses       5605     5605           
  Partials     1132     1132           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9a067a...ef22290. Read the comment docs.

@jadarsie
Copy link
Member

jadarsie commented Jul 8, 2020

/lgtm

@acs-bot
Copy link

acs-bot commented Jul 8, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haofan-ms, jadarsie
To complete the pull request process, please assign jackfrancis
You can assign the PR to them by writing /assign @jackfrancis in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jadarsie jadarsie merged commit 509ea12 into Azure:master Jul 8, 2020
@haofan-ms haofan-ms deleted the update-e2e branch August 11, 2020 05:07
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants