Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: update go toolchain to 1.14.4 #3596

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Conversation

mboersma
Copy link
Member

Reason for Change:

See https://github.com/deis/docker-go-dev/releases/tag/v1.27.3

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #3596 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3596   +/-   ##
=======================================
  Coverage   73.15%   73.16%           
=======================================
  Files         147      147           
  Lines       25124    25129    +5     
=======================================
+ Hits        18380    18385    +5     
  Misses       5612     5612           
  Partials     1132     1132           
Impacted Files Coverage Δ
pkg/api/addons.go 97.77% <100.00%> (+<0.01%) ⬆️
pkg/engine/armvariables.go 86.33% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb83c22...2379faa. Read the comment docs.

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Jul 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma merged commit 9c028a4 into Azure:master Jul 14, 2020
@mboersma mboersma deleted the update-toolchain branch July 14, 2020 22:39
@mboersma
Copy link
Member Author

I updated DEIS_GO_DEV_IMAGE to match this on the upstream Jenkins instance. ✔️

penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
* chore: update go toolchain to 1.14.4

See https://github.com/deis/docker-go-dev/releases/tag/v1.27.3

* style: placate stricter nil-checking linter
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants