Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: ServiceCidr + DNSServiceIP validation error message #360

Merged

Conversation

jackfrancis
Copy link
Member

Reason for Change:

Fix misleading validation message for DNSServiceIP / ServiceCidr configuration combinations.

Issue Fixed:

Fixes #349

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #360 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   53.22%   53.22%           
=======================================
  Files          95       95           
  Lines       14224    14224           
=======================================
  Hits         7571     7571           
  Misses       5988     5988           
  Partials      665      665

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Jan 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 7066350 into Azure:master Jan 23, 2019
@jackfrancis jackfrancis deleted the fix-servicecidr-dnsserviceip-validation branch January 23, 2019 23:24
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixed up error messages when validating DNSServiceIP and ServiceCidr
3 participants