-
Notifications
You must be signed in to change notification settings - Fork 527
feat: azure kms provider as static pod #3667
Conversation
bdef495
to
f874164
Compare
Codecov Report
@@ Coverage Diff @@
## master #3667 +/- ##
=======================================
Coverage 73.19% 73.20%
=======================================
Files 148 148
Lines 25394 25428 +34
=======================================
+ Hits 18587 18614 +27
- Misses 5671 5679 +8
+ Partials 1136 1135 -1
Continue to review full report at Codecov.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
0b5e308
to
3f13f70
Compare
This PR is ready for review. cc @ritazh |
@@ -159,13 +159,6 @@ write_files: | |||
content: !!binary | | |||
{{CloudInitData "labelNodesSystemdService"}} | |||
|
|||
- path: /etc/systemd/system/kms.service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So basically we are deprecating all systemd foo in favor of everything being deliverd via daemonset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually nevermind I see it's a system Pod
@@ -113,7 +113,6 @@ const ( | |||
kubernetesMasterGenerateProxyCertsScript = "k8s/cloud-init/artifacts/generateproxycerts.sh" | |||
kubernetesCustomSearchDomainsScript = "k8s/cloud-init/artifacts/setup-custom-search-domains.sh" | |||
kubeletSystemdService = "k8s/cloud-init/artifacts/kubelet.service" | |||
kmsSystemdService = "k8s/cloud-init/artifacts/kms.service" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to delete the parts/k8s/cloud-init/artifacts/kms.service
file entirely from the codebase now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted parts/k8s/cloud-init/artifacts/kms.service
964161d
to
2abe617
Compare
azure kms provider as static pod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aramase, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Things to complete as part of this PR:
Issue Fixed:
Requirements:
Notes:
Tested cluster upgrade:
enableEncryptionWithExternalKms: true
.kubectl get secrets
returns the decoded content.