This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: don't wait for pod-security-policy spec if disabled #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfrancis
force-pushed
the
fix-pod-security-policy-disabled
branch
from
2c3963a
to
b02d8c7
Compare
Codecov Report
@@ Coverage Diff @@
## master #3673 +/- ##
=======================================
Coverage 73.15% 73.16%
=======================================
Files 147 147
Lines 25309 25312 +3
=======================================
+ Hits 18516 18519 +3
Misses 5655 5655
Partials 1138 1138
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR ensures that we don't wait for a pod-security-policy yaml spec during cluster bootstrapping if the pod-security-policy addon has been explicitly disabled.
To be clear, explicitly disabling that addon will result in a non-working cluster, as privileged escalation capabilities won't be allowed, which various kube-system components require. But this PR will allow folks to deliver their own equivalent PodSecurityPolicy configs if they wish and still return from CSE.
Issue Fixed:
Fixes #3656
Requirements:
Notes: