This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: validate "basic" LB and fix related unit tests #3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3690 +/- ##
=======================================
Coverage 73.14% 73.14%
=======================================
Files 147 147
Lines 25220 25220
=======================================
Hits 18448 18448
Misses 5638 5638
Partials 1134 1134
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Makes load balancer type validation agree that "basic" and "Basic" are both ok.
In making this trivial fix, I noticed there was already a test case that specified "basic", but that was passing. It turns out that set of tests was ignoring any
errreturn, so I fixed that so the UT will actually prevent this behavior from regressing.Issue Fixed:
Fixes #3661
Requirements:
Notes: