feat: configurable microsoft apt repository #3698
Conversation
|
@DavidParks8 FYI |
Codecov Report
@@ Coverage Diff @@
## master #3698 +/- ##
=======================================
Coverage 73.15% 73.16%
=======================================
Files 147 147
Lines 25309 25315 +6
=======================================
+ Hits 18516 18522 +6
Misses 5655 5655
Partials 1138 1138
Continue to review full report at Codecov.
|
| properties.MasterProfile.Count = 1 | ||
| mockCS.setOrchestratorDefaults(false, false) | ||
| if properties.OrchestratorProfile.KubernetesConfig.MicrosoftAptRepositoryURL != DefaultMicrosoftAptRepositoryURL { | ||
| t.Fatalf("MicrosoftAptRepositoryURL did not have the expected size, got %s, expected %s", |
There was a problem hiding this comment.
| t.Fatalf("MicrosoftAptRepositoryURL did not have the expected size, got %s, expected %s", | |
| t.Fatalf("MicrosoftAptRepositoryURL did not have the expected contents, got %s, expected %s", |
| properties.OrchestratorProfile.KubernetesConfig.MicrosoftAptRepositoryURL = "custom.packages.com" | ||
| mockCS.setOrchestratorDefaults(false, false) | ||
| if properties.OrchestratorProfile.KubernetesConfig.MicrosoftAptRepositoryURL != "custom.packages.com" { | ||
| t.Fatalf("MicrosoftAptRepositoryURL did not have the expected size, got %s, expected custom.packages.com", |
There was a problem hiding this comment.
| t.Fatalf("MicrosoftAptRepositoryURL did not have the expected size, got %s, expected custom.packages.com", | |
| t.Fatalf("MicrosoftAptRepositoryURL did not have the expected contents, got %s, expected custom.packages.com", |
| @@ -89,7 +89,8 @@ | |||
| "loadBalancerOutboundIPs": 2, | |||
| "apiServerConfig": { | |||
| "--anonymous-auth": "true" | |||
| } | |||
| }, | |||
| "microsoftAptRepositoryURL": "https://packages.microsoft.com" | |||
There was a problem hiding this comment.
Are you being explicit about the default here for documentation reasons?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
This PR enables configurable override of the default
packages.microsoft.comapt repository for sourcing Ubuntu 16.04-LTS and Ubuntu 18.04-LTS packages.Issue Fixed:
Fixes #3677
Requirements:
Notes: