fix: do not restart addon-manager if a reboot is required #3721
fix: do not restart addon-manager if a reboot is required #3721
Conversation
@CecileRobertMichon: GitHub didn't allow me to request PR reviews from the following users: Michael-Sinz. Note that only Azure members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #3721 +/- ##
=======================================
Coverage 73.16% 73.16%
=======================================
Files 147 147
Lines 25318 25318
=======================================
Hits 18525 18525
Misses 5655 5655
Partials 1138 1138
Continue to review full report at Codecov.
|
fa53af1
to
a939db1
Compare
a939db1
to
24ed0b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Related to #3668 (comment)
Seeing some clusters fail with exit 36 recently where CSE failed to get the addon-manager pod as part of ensureAddons().
This PR might not fix the underlying root cause but we should not be getting/restarting pods when the vm is marked for reboot so this PR addresses that.
/cc @mboersma @Michael-Sinz
Issue Fixed:
Requirements:
Notes: