Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: update windows default VHD for August #3730

Merged
merged 2 commits into from Aug 21, 2020
Merged

chore: update windows default VHD for August #3730

merged 2 commits into from Aug 21, 2020

Conversation

mainred
Copy link
Member

@mainred mainred commented Aug 20, 2020

Reason for Change:

This PR updates:

  • aks-windows default VHD with August patch, together with hotfixes,
  • WindowsServer version to the one released on August7th.

building VHD pipeline: https://dev.azure.com/AzureContainerUpstream/Kubernetes/_build/results?buildId=10572&view=results
push VHD to marketplace release: https://dev.azure.com/AzureContainerUpstream/Kubernetes/_releaseProgress?_a=release-pipeline-progress&releaseId=749

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added the size/L label Aug 20, 2020
AbelHu
AbelHu previously approved these changes Aug 20, 2020
@jsturtevant
Copy link
Contributor

It looks like the latest Windows Server image was published to the market place could you update the base image version as well at:

WindowsServer2019OSImageConfig = AzureOSImageConfig{
ImageOffer: "WindowsServer",
ImageSku: "2019-Datacenter-Core-with-Containers-smalldisk",
ImagePublisher: "MicrosoftWindowsServer",
ImageVersion: "17763.1339.2007101755",
}

The latest August image:

az vm image show --urn MicrosoftWindowsServer:WindowsServer:2019-Datacenter-Core-with-Containers-smalldisk:latest --query "name" 
"17763.1397.2008070242"

@mainred mainred changed the title [DONT MERGE] chore: update windows default VHD for Auguest chore: update windows default VHD for Auguest Aug 21, 2020
@mainred
Copy link
Member Author

mainred commented Aug 21, 2020

Updated windows-server version per James as well
ping @jsturtevant @AbelHu to take another look.

@jsturtevant
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #3730 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3730   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files         147      147           
  Lines       25322    25322           
=======================================
  Hits        18529    18529           
  Misses       5655     5655           
  Partials     1138     1138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49236ab...d2e22f0. Read the comment docs.

@jsturtevant jsturtevant changed the title chore: update windows default VHD for Auguest chore: update windows default VHD for August Aug 21, 2020
@jsturtevant
Copy link
Contributor

/lgtm

@jsturtevant
Copy link
Contributor

/approve

@jsturtevant jsturtevant merged commit 6315a93 into Azure:master Aug 21, 2020
@acs-bot
Copy link

acs-bot commented Aug 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, mainred

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jackfrancis pushed a commit that referenced this pull request Aug 25, 2020
* chore: update windows default VHD for August
* Update WindowsServer version to the August released one
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
* chore: update windows default VHD for August
* Update WindowsServer version to the August released one
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants