Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: update NPM to latest version 1.1.7 #3740

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

csfmomo
Copy link
Contributor

@csfmomo csfmomo commented Aug 22, 2020

feat: Update NPM to latest version 1.1.7

  • [ X] tested upgrade from previous version

@mboersma
Copy link
Member

@csfmomo could you git commit --amend and force push this so the commit message is conventional commit style? Something like:

chore: update NPM to latest version 1.1.7

@csfmomo
Copy link
Contributor Author

csfmomo commented Aug 24, 2020

@csfmomo could you git commit --amend and force push this so the commit message is conventional commit style? Something like:

chore: update NPM to latest version 1.1.7

Sure

@mboersma mboersma changed the title Update NPM to latest version 1.1.7 chore: update NPM to latest version 1.1.7 Aug 31, 2020
@mboersma
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #3740 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3740      +/-   ##
==========================================
+ Coverage   73.17%   73.20%   +0.02%     
==========================================
  Files         147      148       +1     
  Lines       25322    25372      +50     
==========================================
+ Hits        18529    18573      +44     
- Misses       5655     5663       +8     
+ Partials     1138     1136       -2     
Impacted Files Coverage Δ
pkg/api/k8s_versions.go 100.00% <ø> (ø)
pkg/api/common/versions.go 96.84% <0.00%> (ø)
pkg/engine/templates_generated.go 53.42% <0.00%> (ø)
pkg/versions/compare.go 65.51% <0.00%> (ø)
pkg/api/addons.go 97.80% <0.00%> (+0.01%) ⬆️
pkg/api/defaults.go 92.91% <0.00%> (+0.06%) ⬆️
pkg/api/vlabs/validate.go 80.15% <0.00%> (+0.15%) ⬆️
pkg/operations/kubernetesupgrade/upgrader.go 64.27% <0.00%> (+0.71%) ⬆️
pkg/engine/params_k8s.go 85.52% <0.00%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9289247...181a4a2. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Aug 31, 2020
@jackfrancis jackfrancis merged commit 1114eb8 into Azure:master Aug 31, 2020
@acs-bot
Copy link

acs-bot commented Aug 31, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csfmomo, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants