Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: add new Azure VM SKUs #3744

Merged
merged 1 commit into from Aug 24, 2020

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Aug 24, 2020

Reason for Change:

80 new SKUs were picked up by the aks-engine get-skus dev command. This adds them to the allowed list and to unit tests.

List of new SKUs
  • Standard_D16_v4
  • Standard_D16d_v4
  • Standard_D16ds_v4
  • Standard_D16s_v4
  • Standard_D2_v4
  • Standard_D2d_v4
  • Standard_D2ds_v4
  • Standard_D2s_v4
  • Standard_D32_v4
  • Standard_D32d_v4
  • Standard_D32ds_v4
  • Standard_D32s_v4
  • Standard_D48_v4
  • Standard_D48d_v4
  • Standard_D48ds_v4
  • Standard_D48s_v4
  • Standard_D4_v4
  • Standard_D4d_v4
  • Standard_D4ds_v4
  • Standard_D4s_v4
  • Standard_D64_v4
  • Standard_D64d_v4
  • Standard_D64ds_v4
  • Standard_D64s_v4
  • Standard_D8_v4
  • Standard_D8d_v4
  • Standard_D8ds_v4
  • Standard_D8s_v4
  • Standard_E16-4ds_v4
  • Standard_E16-4s_v4
  • Standard_E16-8ds_v4
  • Standard_E16-8s_v4
  • Standard_E16_v4
  • Standard_E16d_v4
  • Standard_E16ds_v4
  • Standard_E16s_v4
  • Standard_E20_v4
  • Standard_E20d_v4
  • Standard_E20ds_v4
  • Standard_E20s_v4
  • Standard_E2_v4
  • Standard_E2d_v4
  • Standard_E2ds_v4
  • Standard_E2s_v4
  • Standard_E32-16ds_v4
  • Standard_E32-16s_v4
  • Standard_E32-8ds_v4
  • Standard_E32-8s_v4
  • Standard_E32_v4
  • Standard_E32d_v4
  • Standard_E32ds_v4
  • Standard_E32s_v4
  • Standard_E4-2ds_v4
  • Standard_E4-2s_v4
  • Standard_E48_v4
  • Standard_E48d_v4
  • Standard_E48ds_v4
  • Standard_E48s_v4
  • Standard_E4_v4
  • Standard_E4d_v4
  • Standard_E4ds_v4
  • Standard_E4s_v4
  • Standard_E64-16ds_v4
  • Standard_E64-16s_v4
  • Standard_E64-32ds_v4
  • Standard_E64-32s_v4
  • Standard_E64_v4
  • Standard_E64d_v4
  • Standard_E64ds_v4
  • Standard_E64s_v4
  • Standard_E8-2ds_v4
  • Standard_E8-2s_v4
  • Standard_E8-4ds_v4
  • Standard_E8-4s_v4
  • Standard_E8_v4
  • Standard_E8d_v4
  • Standard_E8ds_v4
  • Standard_E8s_v4
  • Standard_M416-208ms_v2
  • Standard_M416-208s_v2

Issue Fixed:

Requirements:

Notes:

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Aug 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #3744 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3744   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files         147      147           
  Lines       25322    25322           
=======================================
  Hits        18529    18529           
  Misses       5655     5655           
  Partials     1138     1138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c917d11...4a65424. Read the comment docs.

@jackfrancis jackfrancis merged commit 28f403f into Azure:master Aug 24, 2020
@mboersma mboersma deleted the hey-people-new-skyoos branch August 24, 2020 23:00
jackfrancis pushed a commit that referenced this pull request Aug 25, 2020
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants