Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: add private key input to e2e suite + keep all junit result files #3747

Merged
merged 15 commits into from
Sep 11, 2020
Merged

test: add private key input to e2e suite + keep all junit result files #3747

merged 15 commits into from
Sep 11, 2020

Conversation

haofan-ms
Copy link
Contributor

Reason for Change:

Issue Fixed:

Requirements:

Notes:

haofan-ms and others added 2 commits August 25, 2020 09:49
@haofan-ms
azs changes for akse (#3)
ec3c714 
* azs changes for akse

* use python 2.7 pem for upgrade from akse-v0.48.0
@haofan-ms
fix typo
65d14c7
@acs-bot acs-bot added the size/M label Aug 25, 2020
@haofan-ms haofan-ms changed the title fix: Azure Stack E2E fixes (allowing using existing SSH key for k8s cluster provisioning & generating separete junit files for different stages)) fix: Azure Stack E2E fixes (allowing using existing SSH key for k8s cluster provisioning & generating separete junit files for different stages) Aug 25, 2020
@haofan-ms haofan-ms changed the title fix: Azure Stack E2E fixes (allowing using existing SSH key for k8s cluster provisioning & generating separete junit files for different stages) fix: Azure Stack E2E fixes (allowing use existing SSH key for k8s cluster provisioning & generating separete junit files for different stages) Aug 25, 2020
@codecov
Copy link

codecov bot commented Aug 25, 2020 •
edited

Codecov Report

Merging #3747 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3747   +/-   ##
=======================================
  Coverage   73.19%   73.19%           
=======================================
  Files         148      148           
  Lines       25394    25394           
=======================================
  Hits        18587    18587           
  Misses       5671     5671           
  Partials     1136     1136

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 001ec9b...c382313. Read the comment docs.

jadarsie
jadarsie suggested changes Aug 25, 2020
View reviewed changes
test/e2e/cluster.sh Outdated Show resolved Hide resolved
test/e2e/config/config.go Outdated Show resolved Hide resolved
test/e2e/config/config.go Outdated Show resolved Hide resolved
test/e2e/runner/cli_provisioner.go Outdated Show resolved Hide resolved
@haofan-ms haofan-ms changed the title fix: Azure Stack E2E fixes (allowing use existing SSH key for k8s cluster provisioning & generating separete junit files for different stages) test: Use existing SSH key & generate stage Junit reports for Azure Stack E2E tests Aug 26, 2020
jadarsie
jadarsie reviewed Aug 26, 2020
View reviewed changes
test/e2e/cluster.sh Outdated Show resolved Hide resolved
test/e2e/cluster.sh Outdated Show resolved Hide resolved
@jadarsie jadarsie changed the title test: Use existing SSH key & generate stage Junit reports for Azure Stack E2E tests [WIP] test: Use existing SSH key & generate stage Junit reports for Azure Stack E2E tests Aug 26, 2020
jadarsie
jadarsie suggested changes Sep 3, 2020
View reviewed changes
test/e2e/cluster.sh Outdated Show resolved Hide resolved
@acs-bot acs-bot added size/L and removed size/M labels Sep 3, 2020
@acs-bot acs-bot added size/M and removed size/L labels Sep 3, 2020
jadarsie
jadarsie reviewed Sep 4, 2020
View reviewed changes
test/e2e/cluster.sh Outdated Show resolved Hide resolved
test/e2e/runner/cli_provisioner.go Outdated Show resolved Hide resolved
@jadarsie jadarsie changed the title [WIP] test: Use existing SSH key & generate stage Junit reports for Azure Stack E2E tests [WIP] test: add private key input to e2e suite + keep all junit result files Sep 4, 2020
@jadarsie jadarsie changed the title [WIP] test: add private key input to e2e suite + keep all junit result files test: add private key input to e2e suite + keep all junit result files Sep 8, 2020
jackfrancis
jackfrancis approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Sep 11, 2020
@jackfrancis jackfrancis merged commit 1457cb3 into Azure:master Sep 11, 2020
@acs-bot
Copy link

acs-bot commented Sep 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haofan-ms, jackfrancis, jadarsie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haofan-ms haofan-ms mentioned this pull request Sep 14, 2020
Merged
4 tasks
@fmotrifork fmotrifork mentioned this pull request Sep 21, 2020
Merged
@haofan-ms haofan-ms deleted the azs-fixes branch October 9, 2020 17:07
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
@haofan-ms @penggu
test: add private key input to e2e suite + keep all junit result files (
f4c2cae 
Azure#3747)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackfrancis jackfrancis jackfrancis approved these changes

@jadarsie jadarsie jadarsie approved these changes

Assignees

@jackfrancis jackfrancis

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haofan-ms @acs-bot @jackfrancis @jadarsie